dead ES regions with corrected energy for each plane. Fixes inconsistency in regression training

[argiro]

No description provided.

[cmsbuild]

A new Pull Request was created by @argiro for CMSSW_9_0_X.

It involves the following packages:

RecoParticleFlow/PFClusterTools

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @rafaellopesdesa, @bachtis, @cbernet this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[slava77]

@argiro
please provide some details on expected changes in performance.
Ideally, a link to slides or other similar document would work.

Thank you.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17247/console Started: 2017/01/11 19:02

[cmsbuild]

+1
Tested at: 72dba60
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17145/17247/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17145/17247/summary.html

[slava77]

@argiro in case you missed,
please respond to #17145 (comment)

Thank you

[argiro]

@slava77 sorry for the late reply, here is some material in slide 4.
Presumably there will be no appreciable changes in the comparison, but the way in which the energy is reassigned to the dead/working plane matters for the regression

https://indico.cern.ch/event/578798/contributions/2398509/attachments/1386873/2111046/20161212_ES_Status.pdf

[slava77]

+1

for #17145 72dba60

• changes are in line with the description in the supplied slides
• jenkins tests pass and comparisons with baseline show no differences
• local tests with several other available matrix data workflows for 2016 show no differences in the outputs ... and the reason is that the GT for data uses ESEEIntercalibConstantsRcd ESEEIntercalibConstants_LG_offline_data_default which has gammaLow1,2=1 and these lead to identical values for PS before and after the changes in this PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1