Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-added removed line as it may be needed #1715

Merged
merged 1 commit into from Dec 7, 2013

Conversation

apfeiffer1
Copy link
Contributor

re-added removed line as it may be needed. It won't compile until the corresponding function (finalType()) is implemented in the framework class, so you may want to keep the merge into ROOT-6 branch until this is done.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2013

A new Pull Request was created by @apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_0_ROOT6_X.

re-added removed line as it may be needed

It involves the following packages:

CondCore/DBCommon

@apfeiffer1, @nclopezo, @demattia, @cmsbuild, @rcastello, @ggovi can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@apfeiffer1
Copy link
Contributor Author

+1

1 similar comment
@rcastello
Copy link

+1

@apfeiffer1
Copy link
Contributor Author

hmm ... why is this still labelled "pending" for DB and AlCa - even if both gave the "+1" 12 and 3 hours ago ??
something wrong with the robot ???

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

@ktf
Copy link
Contributor

ktf commented Dec 7, 2013

@apfeiffer1 Some changes in cms-bot recently introduced a bug which made the bot fail in case of missing release manager for a branch. Now fixed.

ktf added a commit that referenced this pull request Dec 7, 2013
ROOT6 -- Re-added removed line as it may be needed
@ktf ktf merged commit 92c3476 into cms-sw:CMSSW_7_0_ROOT6_X Dec 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants