Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix L1TCaloParamsCompare operator== #17150

Merged
merged 1 commit into from Jan 13, 2017

Conversation

Dr15Jones
Copy link
Contributor

The operator== function only compared the first object to itself
rather than comparing the first object to the second object.
Found by gcc 6.2.

The operator== function only compared the first object to itself
rather than comparing the first object to the second object.
Found by gcc 6.2.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_0_X.

It involves the following packages:

L1TriggerConfig/Utilities

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 11, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17242/console Started: 2017/01/11 16:28

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@rekovic - and here.

@rekovic
Copy link
Contributor

rekovic commented Jan 12, 2017

Thanks @Dr15Jones

@rekovic
Copy link
Contributor

rekovic commented Jan 12, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1310df2 into cms-sw:CMSSW_9_0_X Jan 13, 2017
@Dr15Jones Dr15Jones deleted the gcc6WarningFix branch February 13, 2017 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants