Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix self-comparison in L1MuGMTExtendedCand #17151

Merged

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jan 11, 2017

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_9_0_X.

It involves the following packages:

DataFormats/L1GlobalMuonTrigger

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17249/console Started: 2017/01/12 11:44

@davidlange6
Copy link
Contributor

@rekovic - any idea if this function is used? This bug can affect any results from it

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@rekovic
Copy link
Contributor

rekovic commented Jan 12, 2017

@davidlt, Thanks.

@davidlange6, This is an old code not in use. It has no affect on Run II.

@rekovic
Copy link
Contributor

rekovic commented Jan 12, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlt
Copy link
Contributor Author

davidlt commented Jan 12, 2017

@rekovic the last time it was modified (meaningful) was in 2007. If it's that old and not used, maybe we can remove it from the release?

@davidlange6
Copy link
Contributor

yes, lets get rid of obsolete code. Thanks @rekovic

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fcfbf51 into cms-sw:CMSSW_9_0_X Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants