Replace import * when modules are imported only to be cloned

[wddgit]

No description provided.

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_9_0_X.

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[slava77]

should this better be as _m so that someplace else with electronPFIsolationDepositsPAT_cff import * doesn't end up with a rogue m?

[wddgit]

Yes. I agree that would be better. I will update the PR soon.

What I did was enough to keep unwanted things out of the Process object and the list of unscheduled modules. But you are right, the "m" symbol would show up in the symbol table of the importing modules, which is unnecessary and could cause problems if anyone tried to use it because of conflicts.

[wddgit]

I updated the PR with the change from m to _m suggested by Slava. I do not know why, but I did not see the email I usually see after updating a PR, but it should be ready to be tested now.

[slava77]

@cmsbuild please test

@smuzaffar is this the normal behavior of the bot (to send no messages on a PR that had no other state changes like no tests were started and no labels were modified yet, but there was a new commit)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17259/console Started: 2017/01/12 22:19

[smuzaffar]

@slava77 , no it is not a normal behavior. This only happens when there is no comment between new commit the time when bot had recognized the PR.

[cmsbuild]

+1
Tested at: 7093224
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17153/17259/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17153/17259/summary.html

[monttj]

+1

[slava77]

+1

for #17153 7093224

• changes are as described
• jenkins tests pass and comparisons with the baseline show no differences as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar