Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit assoc for phase2 #17161

Merged
merged 2 commits into from Jan 16, 2017
Merged

Hit assoc for phase2 #17161

merged 2 commits into from Jan 16, 2017

Conversation

wmtford
Copy link
Contributor

@wmtford wmtford commented Jan 12, 2017

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtford (Bill Ford) for CMSSW_9_0_X.

It involves the following packages:

SimTracker/TrackerHitAssociation

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @sdevissc, @GiacomoSguazzoni, @rovere, @VinInn, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@wmtford
Copy link
Contributor Author

wmtford commented Jan 12, 2017

Modify TracerkHitAssociator to work with Phase 2 simHit collections. Specifically, allow a collection to contain simHits from more than one subdetector. SimHits are extracted from a map whose value is the vector of simHits and whose key is the collection index. Previously the key was a pair (subDet, TofBin), which in Phase 2 is no longer one-to-one with the collection. Now an additional map with this key points to the collection index.

@civanch
Copy link
Contributor

civanch commented Jan 13, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17271/console Started: 2017/01/13 17:02
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17280/console Started: 2017/01/13 17:55

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Jan 15, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8f7e02b into cms-sw:CMSSW_9_0_X Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants