Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced tab with space to avoid gcc 6.3 warning in L1Trigger/L1TCommon #17174

Merged
merged 1 commit into from Jan 14, 2017

Conversation

Dr15Jones
Copy link
Contributor

Because of the different possible spacing used for tabs, gcc 6.3
was warning of a line after an if that might appear to visually
be part of the if but is, in fact, not. Switching from tabs to
using spaces, which is consistent with the rest of the document,
removes the warning.

Because of the different possible spacing used for tabs, gcc 6.3
was warning of a line after an `if` that might appear to visually
be part of the `if` but is, in fact, not. Switching from tabs to
using spaces, which is consistent with the rest of the document,
removes the warning.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_0_X.

It involves the following packages:

L1Trigger/L1TCommon

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17282/console Started: 2017/01/13 17:55

@Dr15Jones
Copy link
Contributor Author

@davidlt here's another gcc 6.3 warnings fix (I noticed you had made some changes yesterday fixing other ones).

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@davidlange6 davidlange6 merged commit 98a335b into cms-sw:CMSSW_9_0_X Jan 14, 2017
@Dr15Jones Dr15Jones deleted the fixSpacing branch February 13, 2017 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants