Add timing detectors to GeomDetEnumerators #17176
Conversation
|
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_9_0_X. It involves the following packages: Geometry/CommonDetUnit @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@cmsbuild please test |
|
urgent |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 4bfb05c You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-13-1100/src/CalibFormats/SiStripObjects/test/UnitTests/TestSiStripDelay.cc:5:0:
/cvmfs/cms-ib.cern.ch/2017-02/slc6_amd64_gcc530/external/cppunit/1.12.1/include/cppunit/ui/text/TestRunner.h:1:1: warning: null character(s) ignored
>> Building binary runFastHadd
Copying tmp/slc6_amd64_gcc530/src/RecoMET/METProducers/test/testRecoMETMETProducers/testRecoMETMETProducers to productstore area:
/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-01-13-1100/external/slc6_amd64_gcc530/lib/libHepMCfio.a: file not recognized: File format not recognized
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc6_amd64_gcc530/src/RecoRomanPot/RecoFP420/src/RecoRomanPotRecoFP420/libRecoRomanPotRecoFP420.so] Error 1
Leaving library rule at SLHCUpgradeSimulations/Geometry
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-13-1100/src/CalibFormats/SiStripObjects/test/UnitTests/MasterTest.cpp: In function 'int main(int, char**)':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-13-1100/src/CalibFormats/SiStripObjects/test/UnitTests/MasterTest.cpp:34:12: error: 'CppUnit::TextUi' has not been declared
CppUnit::TextUi::TestRunner runner;
|
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
@cmsbuild please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 4bfb05c You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: >> Building binary runTheWhiteRabbit /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-13-2300/src/CalibFormats/SiStripObjects/test/UnitTests/MasterTest.cpp:16:40: warning: /cvmfs/cms-ib.cern.ch/2017-02/slc6_amd64_gcc530/external/cppunit/1.12.1/include/cppunit/ui/text/TestRunner.h is shorter than expected /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-13-2300/src/CalibFormats/SiStripObjects/test/UnitTests/MasterTest.cpp:23:47: warning: /cvmfs/cms-ib.cern.ch/2017-02/slc6_amd64_gcc530/external/cppunit/1.12.1/include/cppunit/BriefTestProgressListener.h is shorter than expected Leaving library rule at DataFormats/MuonDetId /cvmfs/cms-ib.cern.ch/2017-02/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_0_X_2017-01-12-2300/lib/slc6_amd64_gcc530/libDataFormatsFP420Cluster.so: file not recognized: File format not recognized collect2: error: ld returned 1 exit status >> Building edm plugin tmp/slc6_amd64_gcc530/src/Fireworks/Geometry/plugins/FireworksGeometryMFProducerPlugin/libFireworksGeometryMFProducerPlugin.so >> Building edm plugin tmp/slc6_amd64_gcc530/src/DQMServices/Components/test/TestDQMToolsPlugins/libTestDQMToolsPlugins.so >> Building shared library tmp/slc6_amd64_gcc530/src/Fireworks/Eve/src/FireworksEve/libFireworksEve.so gmake: *** [tmp/slc6_amd64_gcc530/src/RecoRomanPot/RecoFP420/src/RecoRomanPotRecoFP420/libRecoRomanPotRecoFP420.so] Error 1 /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-13-2300/src/CalibFormats/SiStripObjects/test/UnitTests/MasterTest.cpp: In function 'int main(int, char**)': |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Hi, I can confirm that this builds just fine on cmslpc41. There's some problem with lxplus. @davidlange6 It would be helpful if we can get this PR in since it triggers so much recompilation. |
|
@cmsbuild please test may as well try my luck |
|
The tests are being triggered in jenkins. |
cmsbuild
added
comparison-pending
tests-pending
tests-started
and removed
tests-rejected
tests-pending
labels
|
Comparison job queued. |
|
As far as I can tell, no changes in the standard comparisons. |
|
Hi @lgray - is there something that summarizes where these changes are going? (sorry, I'm not following this upgrade closely) |
|
@davidlange6 Added a small summary in the PR description. |
|
Since I'd like to be able to distribute this as a recipe and I have a deadline the end of this month, and checking out 464 packages is a bit much, I marked this urgent. |
|
+1 |
This PR adds the timing detector layers such that they can be easily used in tracking geometries.
Pushing this now since it pulls down 464 packages.
This the first necessary step in developing tracking tools for the timing layer studies for the phase 2 upgrade. It allows for straightforward integration of the new detectors into the tracking geometries so that we can use tracks to pick timing hits. The next phase, after we establish the efficiency and purity that we can pick hits, is to extend the propagation and kalman fitting code to include an estimate of the particle's t0 so that we can take the time at detector back to the vertex using only reconstructed information.