New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace TMVA::Factory->SetInputTrees with TMVA::DataLoader #17185
Conversation
The change is needed for ROOT 6.07.00 and above, i.e. for forthcoming ROOT 6.08. The new release introduces a new TVMA class: TMVA::DataLoader. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
A new Pull Request was created by @cmsbuild for CMSSW_9_0_X. It involves the following packages: PhysicsTools/MVATrainer @cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test with cms-sw/cmsdist#2768 |
The tests are being triggered in jenkins. |
-1 Tested at: 4a1b99c The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test TestFWCoreIntegrationStandalone had ERRORS The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
backport of #15737
The change is needed for ROOT 6.07.00 and above, i.e. for forthcoming
ROOT 6.08. The new release introduces a new TVMA class:
TMVA::DataLoader.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch