Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TMVA::Factory->SetInputTrees with TMVA::DataLoader #17185

Merged
merged 1 commit into from Jan 17, 2017

Conversation

cmsbuild
Copy link
Contributor

backport of #15737

The change is needed for ROOT 6.07.00 and above, i.e. for forthcoming
ROOT 6.08. The new release introduces a new TVMA class:
TMVA::DataLoader.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

The change is needed for ROOT 6.07.00 and above, i.e. for forthcoming
ROOT 6.08. The new release introduces a new TVMA class:
TMVA::DataLoader.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_9_0_X.

It involves the following packages:

PhysicsTools/MVATrainer

@cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#2768

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jan 16, 2017

@cmsbuild
Copy link
Contributor Author

-1

Tested at: 4a1b99c

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
27ddd59
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17185/91/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17185/91/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17185/91/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestFWCoreIntegrationStandalone had ERRORS
---> test runtestPythonAnalysis had ERRORS
---> test testRecoMETMETProducers had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
27ddd59
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17185/91/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17185/91/git-merge-result

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

@smuzaffar smuzaffar merged commit 1112a16 into CMSSW_9_0_X Jan 17, 2017
@Dr15Jones
Copy link
Contributor

@smuzaffar smuzaffar deleted the backport-CMSSW_9_0_X-15737 branch January 21, 2017 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants