Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace throw specifier (deprecated) with noexcept (C++11) #17213

Merged
merged 1 commit into from Jan 23, 2017

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jan 19, 2017

ISO C++17 no more supports dynamic exception specifications. Starting
C++11 noexcept and noexcept(expression) were introduced, where if
expression is false it means that function/method potentially can throw
something. Simply put, now you can mark function as not throwing
anything or potentially throwing something. Again, this was deprecated
in C++11 and finally removed in C++17 to my understanding.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

ISO C++17 no more supports dynamic exception specifications. Starting
C++11 noexcept and noexcept(expression) were introduced, where if
expression is false it means that function/method potentially can throw
something. Simply put, now you can mark function as not throwing
anything or potentially throwing something. Again, this was deprecated
in C++11 and finally removed in C++17 to my understanding.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_9_0_X.

It involves the following packages:

OnlineDB/CSCCondDB
OnlineDB/EcalCondDB

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17329/console Started: 2017/01/19 16:15

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17213/17329/summary.html

Alternative comparison was/were failed for workflow(s):
25202.0
25.0
1306.0
21234.0
1003.0
23234.0
140.53
136.731
1330.0
1000.0
135.4
10024.0
5.1
1001.0
10021.0
50202.0
20034.0
9.0
4.22

@davidlt
Copy link
Contributor Author

davidlt commented Jan 21, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 21, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17367/console Started: 2017/01/21 19:45

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@ggovi
Copy link
Contributor

ggovi commented Jan 23, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 071e0d9 into cms-sw:CMSSW_9_0_X Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants