New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace throw specifier (deprecated) with noexcept (C++11) #17213
Conversation
ISO C++17 no more supports dynamic exception specifications. Starting C++11 noexcept and noexcept(expression) were introduced, where if expression is false it means that function/method potentially can throw something. Simply put, now you can mark function as not throwing anything or potentially throwing something. Again, this was deprecated in C++11 and finally removed in C++17 to my understanding. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
A new Pull Request was created by @davidlt for CMSSW_9_0_X. It involves the following packages: OnlineDB/CSCCondDB @ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Alternative comparison was/were failed for workflow(s): |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
ISO C++17 no more supports dynamic exception specifications. Starting
C++11 noexcept and noexcept(expression) were introduced, where if
expression is false it means that function/method potentially can throw
something. Simply put, now you can mark function as not throwing
anything or potentially throwing something. Again, this was deprecated
in C++11 and finally removed in C++17 to my understanding.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch