Convert JetConstituentSelector template from legacy to stream filter #17215
Conversation
|
A new Pull Request was created by @knoepfel (Kyle Knoepfel) for CMSSW_9_0_X. It involves the following packages: CommonTools/RecoAlgos @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
Shouldn't have any problems, from what I can see. |
| class JetConstituentSelector : public edm::EDFilter { | ||
|
|
||
| template <class T, typename C = std::vector<typename T::ConstituentTypeFwdPtr>> | ||
| class JetConstituentSelector : public edm::stream::EDFilter<> { |
There was a problem hiding this comment.
since "filter_ " is removed and the ::filter method return value is true, there is no more excuse to call this EDFilter.
Please change to EDProducer
There was a problem hiding this comment.
Sounds reasonable, although it requires changing the following configuration files:
RecoJets/Configuration/python/RecoPFJets_cff.py:ak8PFJetsCHSConstituents = cms.EDFilter("PFJetConstituentSelector",
RecoJets/JetProducers/python/ak8PFJetsCS_cfi.py:ak8PFJetsCSConstituents = cms.EDFilter("PFJetConstituentSelector",
There was a problem hiding this comment.
indeed, some related files will need an update.
Please proceed.
|
Pull request #17215 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test I must have missed this was updated a few days ago |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
No description provided.