Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing flagging of gain switch #17218

Merged
merged 1 commit into from Jan 24, 2017

Conversation

argiro
Copy link
Contributor

@argiro argiro commented Jan 20, 2017

Same as #17212 for 80x

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @argiro for CMSSW_8_0_X.

It involves the following packages:

RecoLocalCalo/EcalRecProducers

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Jan 20, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 20, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17341/console Started: 2017/01/20 15:11

@slava77
Copy link
Contributor

slava77 commented Jan 20, 2017

@argiro
Is the modified EcalUncalibRecHitWorkerWeights.cc used in any of existing standard workflows (pp, HI, cosmics; HLT)?
I think it is now, but wanted to double-check.

@argiro
Copy link
Contributor Author

argiro commented Jan 20, 2017

@slava77
no, it's not used in production at the moment, but it will be used for the slew rate fix patch.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 22, 2017

+1

for #17218 1f69ea9

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 003831a into cms-sw:CMSSW_8_0_X Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants