Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIM muon filter #17223

Merged
merged 1 commit into from Feb 13, 2017
Merged

Add SIM muon filter #17223

merged 1 commit into from Feb 13, 2017

Conversation

kskovpen
Copy link
Contributor

@kskovpen kskovpen commented Jan 20, 2017

Backport of #16849 to 71X. It introduces a muon filter applied at G4 level to avoid the generator filter bias. Backport is needed to request the official dataset production. More information is available here: https://indico.cern.ch/event/579787/contributions/2349956/attachments/1361189/2061022/kskovpenBTV20161026.pdf

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kskovpen (skkywriter) for CMSSW_7_1_X.

It involves the following packages:

SimMuon/MCTruth

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @calderona, @HuguesBrun, @trocino this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@civanch
Copy link
Contributor

civanch commented Jan 20, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 20, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17340/console Started: 2017/01/20 14:39

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Jan 23, 2017

+1
this is a harmless addition but I am not sure if it will be used in this release

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@civanch
Copy link
Contributor

civanch commented Jan 23, 2017

@kskovpen , please, extend the PR description on top of this page specifically for 7_1_X (can be edited without a problem), also good to add a reference to a talk where usage of this is justified.

@kskovpen
Copy link
Contributor Author

@civanch Thanks. Done for both backport requests.

@perrozzi
Copy link
Contributor

@kskovpen David is asking to confirm where to filter (end of sim or start of digi). I suppose at the end of SIM as you probably don't want to write unuseful events out (I suppose the filter has quite low efficiency) and they would not be useful for other productions. Is this correct? Can you confirm?

@kskovpen
Copy link
Contributor Author

@perrozzi The expected filter efficiency is about 24%. Yes, probably, one should apply this filter at the end of SIM step to save some disk space. Yes, at the moment we would like to produce one dataset with this filter applied for preliminary tests within the BTV group to see if we can go for a massive production very soon.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 695f219 into cms-sw:CMSSW_7_1_X Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants