Use static_cast to call explicitly conversion operator on TString #17227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TString in ROOT support std::string_view which was added into C++17 standard and CMSSW since GCC 6 is compiled with C++17. GCC 7 will provide a ful C++17 language support and most of C++ standard library. TString defines two conversion operators, one for const char * and one for std::string_view. The std::string can be constructor by both of them thus causing compiler to error on it. Use static_cast to explicitly select conversion operator which would be compatible with previous C++ standards. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_9_0_X. It involves the following packages: PhysicsTools/RecoUtils @cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TString in ROOT support std::string_view which was added into C++17
standard and CMSSW since GCC 6 is compiled with C++17. GCC 7 will
provide a ful C++17 language support and most of C++ standard library.
TString defines two conversion operators, one for const char * and one
for std::string_view. The std::string can be constructor by both of them
thus causing compiler to error on it.
Use static_cast to explicitly select conversion operator which would be
compatible with previous C++ standards.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch