Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLT GCC 7 Cleanup #17239

Merged
merged 2 commits into from
Jan 22, 2017
Merged

HLT GCC 7 Cleanup #17239

merged 2 commits into from
Jan 22, 2017

Commits on Jan 20, 2017

  1. Use static_cast to call explicitly conversion operator on TString 

    TString in ROOT support std::string_view which was added into C++17
standard and CMSSW since GCC 6 is compiled with C++17. GCC 7 will
provide a ful C++17 language support and most of C++ standard library.

TString defines two conversion operators, one for const char * and one
for std::string_view. The std::string can be constructor by both of them
thus causing compiler to error on it.

Use static_cast to explicitly select conversion operator which would be
compatible with previous C++ standards.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
    David Abdurachmanov authored and David Abdurachmanov committed Jan 20, 2017
    Configuration menu
    Copy the full SHA
    2f28bba View commit details
    Browse the repository at this point in the history

  2. Increase buffer (too small according compiler) 

    According GCC the output string could be up to 315 chars long. Adjust
buffer to accommodate that.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
    David Abdurachmanov authored and David Abdurachmanov committed Jan 20, 2017
    Configuration menu
    Copy the full SHA
    a052778 View commit details
    Browse the repository at this point in the history