Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bookhistograms signature #1724

Merged
merged 2 commits into from Dec 9, 2013

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Dec 8, 2013

Pass edm::Run const & and edm::EventSetup const & to bookHistograms method to allow customizations of folders/ME based on stuff coming out of either or both of them. Requested independently by Yutaro and Mia.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2013

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_7_0_X.

Fix bookhistograms signature

It involves the following packages:

DQMServices/Core
DQMServices/Components

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@rovere
Copy link
Contributor Author

rovere commented Dec 8, 2013

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2013

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Dec 9, 2013
DQM fixes -- Fix bookHistograms signature
@ktf ktf merged commit 54daf87 into cms-sw:CMSSW_7_0_X Dec 9, 2013
@rovere rovere deleted the fix-bookhistograms-signature branch October 3, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants