Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce memory used by iso deposits #17241

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Jan 21, 2017

  • add canDeleteEarly for products of CandIsoDepositProducers
  • reduce max cone size for isodeposit collections to be the max cone used to compute isolation sums (removing unused {x, eta, phi} values which just take up space)
  • add fixes to CaloExtractorByAssociator to preserve old behavior (calo energies computed for the candidate itself may be outside of the reduced cone size)

expect essentially no differences apart for edge effects from double-float-double conversions present in the original code (differences from single deposit miss on R=0.4 were visible at 2E-5 rate per muon in PU200).

Net effect in PU200:

  • about 0.24 GB/core reduction in RSS peak
  • 3s/event reduction in time spent by various isodeposit producers (mainly in muPFIsoDeposit*)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_9_0_X.

It involves the following packages:

CommonTools/ParticleFlow
Configuration/StandardSequences
RecoMuon/Configuration
RecoMuon/MuonIsolation
RecoMuon/MuonIsolationProducers
RecoParticleFlow/PFProducer

@cvuosalo, @monttj, @cmsbuild, @franzoni, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @rappoccio, @makortel, @felicepantaleo, @abbiendi, @Martin-Grunewald, @mmarionncern, @battibass, @ahinzmann, @jhgoh, @lgray, @jdolen, @HuguesBrun, @trocino, @rociovilar, @GiacomoSguazzoni, @rafaellopesdesa, @rovere, @VinInn, @bellan, @gkasieczka, @dgulhan, @calderona, @cbernet, @bachtis this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor Author

slava77 commented Jan 21, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 21, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17359/console Started: 2017/01/21 04:44

@slava77 slava77 changed the title reduce memory iso deposits mem reduce memory used by iso deposits Jan 21, 2017
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor Author

slava77 commented Jan 22, 2017

+1

for #17241 1609487

  • jenkins tests pass and comparisons show no differences as expected in the pre-submission tests

@davidlange6 davidlange6 merged commit a653326 into cms-sw:CMSSW_9_0_X Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants