Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization GCC 7 / Clang cleanup #17242

Merged
merged 2 commits into from Feb 3, 2017
Merged

Serialization GCC 7 / Clang cleanup #17242

merged 2 commits into from Feb 3, 2017

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jan 21, 2017

Please, especially review changed done in SmallWORMDict to make sure it does a correct thing.

David Abdurachmanov added 2 commits January 21, 2017 12:07
Use FRIEND_DECL if Clang versio is >= 4.0.0
6a1447d 
FRIEND_DECL was added ~3 months ago according to git log.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Replase boost::bind with lambda
79bc57f 
For some reasons GCC 7 in C++17 was failing to compile if boost::bind or
std::bind is used (both with different errors). Replacing it with a
simpler seems to resolve the issues.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Jan 21, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_9_0_X.

It involves the following packages:

CondFormats/Common
CondFormats/Serialization

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @tocheng this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@davidlt
Copy link
Contributor Author

davidlt commented Jan 21, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 21, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17363/console Started: 2017/01/21 12:14

@cmsbuild
Copy link
Contributor

+1
Tested at: 79bc57f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17242/17363/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17242/17363/summary.html

@davidlt
Copy link
Contributor Author

davidlt commented Jan 26, 2017

I have compared the output of SmallWORMDict_t test and it was the same.

===== Test "SmallWORMDict_t" ====
7 7
38 38
7 10 15 21 26 32 38
BashfulDocDopeyGrumpyHappySleepySneezy
Dopey
Doc at 1
Sleepy at 5

---> test SmallWORMDict_t succeeded

^^^^ End Test SmallWORMDict_t ^^^^

But unit test does not do any testing, just printing stuff.

@davidlt
Copy link
Contributor Author

davidlt commented Jan 30, 2017

ping

@ggovi
Copy link
Contributor

ggovi commented Jan 30, 2017

+1

@davidlt
Copy link
Contributor Author

davidlt commented Feb 2, 2017

Do we have any updates from ALCA?

@ghellwig
Copy link

ghellwig commented Feb 3, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlt
Copy link
Contributor Author

davidlt commented Feb 3, 2017

@davidlange6 could we get this integrated? My hopes are that this should resolve high number of build issues in GCC 7 builds.

@davidlange6 davidlange6 merged commit b26b989 into cms-sw:CMSSW_9_0_X Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available db-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
CMSSW_9_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davidlt @cmsbuild @ggovi @ghellwig @davidlange6