New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iRPC_2D #17252

Merged

cmsbuild merged 11 commits into cms-sw:CMSSW_9_0_X from bapavlov:iRPC_2D

Jan 25, 2017

Contributor

bapavlov commented Jan 23, 2017

Small changes to the digitizer to enable 2D readout for iRPC. The option is configurable with a flag in the configuration file.

bapavlov added 2 commits

January 23, 2017 16:24


          iRPC 2D readout

5d05c4f


          iRPC 2D readout

1662e23

cmsbuild added this to the Next CMSSW_9_0_X milestone

cmsbuild added comparison-pending orp-pending pending-signatures simulation-pending tests-pending labels

Contributor

cmsbuild commented Jan 23, 2017

A new Pull Request was created by @bapavlov for CMSSW_9_0_X.

It involves the following packages:

SimMuon/RPCDigitizer

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@jhgoh this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

Contributor Author

bapavlov commented Jan 23, 2017

@kpedro88
Dear Kevin, it's to inform you that we have make some minor changes in the iRPC digitizer to enable 2D readout.

kpedro88 reviewed

View reviewed changes

SimMuon/RPCDigitizer/src/RPCSimModelTiming.cc

+                //  std::cout<<"deltaw\t"<<deltaw<<std::endl;
+                //  std::cout<<"deltawL\t"<<deltawL<<std::endl;
+                //  std::cout<<"deltawR\t"<<deltawR<<std::endl;

Contributor

kpedro88 Jan 23, 2017

please remove commented lines of code if not needed


          iRPC 2D readout

c4d5e2e

Contributor

cmsbuild commented Jan 23, 2017

Pull request #17252 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

kpedro88 reviewed

View reviewed changes

SimMuon/RPCDigitizer/src/RPCSimModelTiming.cc

+                  return -1;
+                //  std::cout<<"((roll.centreOfStrip(strip)).x())\t"<<((roll.centreOfStrip(strip)).x())<<std::endl;
+                //  std::cout<<"((hit_pos.x())\t"<<(hit_pos.x())<<std::endl;

Contributor

kpedro88 Jan 23, 2017

please remove

kpedro88 reviewed

View reviewed changes

SimMuon/RPCDigitizer/src/RPCSimModelTiming.cc

+                //  std::cout<<"((roll.centreOfStrip(strip)).x())\t"<<((roll.centreOfStrip(strip)).x())<<std::endl;
+                //  std::cout<<"((hit_pos.x())\t"<<(hit_pos.x())<<std::endl;
+              //  double deltaw = fabs((roll.centreOfStrip(strip)).x()-hit_pos.x());

Contributor

kpedro88 Jan 23, 2017

please remove

kpedro88 reviewed

View reviewed changes

SimMuon/RPCDigitizer/src/RPCSimModelTiming.cc

+              positionY-=striplength/2;
+              	  adigi.hasY(true);
+              	  adigi.setY(positionY);
+              //          adigi.setDeltaY(striplength/sqrt(12.));

Contributor

kpedro88 Jan 23, 2017

please remove

kpedro88 reviewed

View reviewed changes

SimMuon/RPCDigitizer/src/RPCSimModelTiming.cc

-              	  double deltaw=roll->centreOfStrip(centralStrip).x()-entr.x();
-              	  if (deltaw<0.) {
+              	  int lr = LeftRightNeighbour(*roll, entr, centralStrip);
+              	  //	  std::cout<<"LeftRightNeighbour(*roll, entr, centralStrip)\t"<<lr<<std::endl;

Contributor

kpedro88 Jan 23, 2017

please remove


          some comments removed

73690b4

Contributor

cmsbuild commented Jan 23, 2017

Pull request #17252 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

Contributor

kpedro88 commented Jan 23, 2017

@cmsbuild please test

Contributor

cmsbuild commented Jan 23, 2017 •

edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17387/console Started: 2017/01/23 17:21

cmsbuild added tests-started and removed tests-pending labels

Contributor

cmsbuild commented Jan 23, 2017

-1

Tested at: 73690b4

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17252/17387/summary.html

I found follow errors while testing this PR

Failed tests: Build

Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-23-1100/src/SimMuon/RPCDigitizer/test/RPCDigiReader.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-23-1100/src/SimMuon/RPCDigitizer/test/RPCFakeEvent.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-23-1100/src/SimMuon/RPCDigitizer/test/RPCEventDump.cc 
>> Building edm plugin tmp/slc6_amd64_gcc530/src/SimMuon/RPCDigitizer/test/RPCEventDump/libRPCEventDump.so
/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-01-23-1100/external/slc6_amd64_gcc530/lib/libCore.so: file not recognized: File truncated
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc6_amd64_gcc530/src/SimMuon/RPCDigitizer/test/RPCEventDump/libRPCEventDump.so] Error 1
Leaving library rule at src/SimMuon/RPCDigitizer/test
>> Building edm plugin tmp/slc6_amd64_gcc530/src/SimMuon/RPCDigitizer/test/RPCFakeEvent/libRPCFakeEvent.so
>> Building edm plugin tmp/slc6_amd64_gcc530/src/SimMuon/RPCDigitizer/test/RPCDigiReader/libRPCDigiReader.so
/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-01-23-1100/external/slc6_amd64_gcc530/lib/libCore.so: file not recognized: File truncated

Contributor

cmsbuild commented Jan 23, 2017

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels

Contributor

kpedro88 commented Jan 23, 2017

@smuzaffar can you check if there is a problematic node?

Contributor

civanch commented Jan 24, 2017

@bapavlov , there are std::cout and std::endl within the class constructor. They should be replaced by edm::LogInfo now

Contributor

kpedro88 commented Jan 24, 2017

please abort


          Merged iRPC_2D from repository bapavlov

311d41d

Contributor

cmsbuild commented Jan 24, 2017

+1
Tested at: 4049537
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17252/17414/summary.html

Contributor

cmsbuild commented Jan 24, 2017

Comparison job queued.


          std::cout changed with edm::LogInfo

9aa294f

Contributor

cmsbuild commented Jan 24, 2017

Pull request #17252 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

Contributor

cmsbuild commented Jan 24, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17252/17414/summary.html

Contributor

civanch commented Jan 25, 2017

please test

Contributor

cmsbuild commented Jan 25, 2017 •

edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17432/console Started: 2017/01/25 12:38

cmsbuild added tests-started and removed tests-pending labels

Contributor

cmsbuild commented Jan 25, 2017

+1
Tested at: 9aa294f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17252/17432/summary.html

Contributor

cmsbuild commented Jan 25, 2017

Comparison job queued.

cmsbuild added tests-approved and removed tests-started labels

Contributor

cmsbuild commented Jan 25, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17252/17432/summary.html

cmsbuild added comparison-available and removed comparison-pending labels

Contributor

civanch commented Jan 25, 2017

+1

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels

Contributor

cmsbuild commented Jan 25, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

Contributor

davidlange6 commented Jan 25, 2017

+1

cmsbuild added orp-approved and removed orp-pending labels

cmsbuild merged commit 10d87d5 into cms-sw:CMSSW_9_0_X

jhgoh mentioned this pull request

RPCRecHit local x position correction #17289

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment