Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread Safe Jet Correctors #17253

Conversation

aperloff
Copy link
Contributor

The point of this pull request is to switch from using the older CorrectionProducers to using the newer CorrectedProducers. The older producers are not thread safe and do not use the consumes features. At some point there was a push to switch to the newer producers (see 1), but we think that some of the code was overlooked. This brings the "new" python files fully in sync and will be a big help to anyone who directly uses the jet correctors.

@rappoccio

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aperloff (Alexx Perloff) for CMSSW_9_0_X.

It involves the following packages:

JetMETCorrections/Configuration

@cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @ahinzmann, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Jan 23, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 23, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17390/console Started: 2017/01/23 18:33

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17253/17390/summary.html

Alternative comparison was/were failed for workflow(s):
25202.0
25.0
1306.0
21234.0
1003.0
23234.0
140.53
136.731
1330.0
1000.0
135.4
10024.0
5.1
8.0
1001.0
10021.0
50202.0
20034.0
9.0
4.22

@slava77
Copy link
Contributor

slava77 commented Jan 23, 2017

@cmsbuild please test
hoping the comparisons will not fail massively this time

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 23, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17391/console Started: 2017/01/23 20:46

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 24, 2017

+1

for #17253 5f16ddf

  • changes are as described
  • jenkins tests pass and comparisons show no difference

@davidlange6 davidlange6 merged commit 6d2bbca into cms-sw:CMSSW_9_0_X Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants