Add back call to consumes within loop in the MixingModule. #17264

ndaci · 2017-01-24T17:33:26Z

This fix adds back a call to consumes in a loop, that is able to load the correct inputs.
This is needed by the TSG-STEAM group in the context of MC Trigger Rate Studies.

Backport in 80X of PR #17262

cmsbuild · 2017-01-24T17:33:48Z

A new Pull Request was created by @ndaci for CMSSW_8_0_X.

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

mdhildreth · 2017-01-31T10:43:02Z

+1

cmsbuild · 2017-01-31T10:43:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17526/console Started: 2017/01/31 11:44

cmsbuild · 2017-01-31T10:43:20Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

mdhildreth · 2017-01-31T10:46:15Z

-1

oops, thought that this had been tested already

davidlange6 · 2017-01-31T10:49:52Z

it was tested and failed tests in 90x.. presumably the same failures will happen here.

…

On Jan 31, 2017, at 11:46 AM, mdhildreth ***@***.***> wrote: -1 oops, thought that this had been tested already — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

cmsbuild · 2017-01-31T11:38:26Z

-1

Tested at: e3f8793

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17264/17526/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

9.0 step2

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@Fake,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Tue Jan 31 12:11:45 2017-date Tue Jan 31 12:10:20 2017 s - exit: 18688
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Tue Jan 31 12:11:57 2017-date Tue Jan 31 12:10:35 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02457/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2017-01-30-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Jan 31 12:11:57 2017-date Tue Jan 31 12:10:35 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Tue Jan 31 12:11:57 2017-date Tue Jan 31 12:10:35 2017 s - exit: 21504
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval25ns,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 : FAILED - time: date Tue Jan 31 12:11:53 2017-date Tue Jan 31 12:10:37 2017 s - exit: 18688
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Tue Jan 31 12:11:47 2017-date Tue Jan 31 12:10:41 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02457/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2017-01-30-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Jan 31 12:11:47 2017-date Tue Jan 31 12:10:41 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Tue Jan 31 12:11:47 2017-date Tue Jan 31 12:10:41 2017 s - exit: 21504
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Tue Jan 31 12:18:58 2017-date Tue Jan 31 12:10:43 2017 s - exit: 18688
cmsDriver.py TTbar_Tauola_8TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Tue Jan 31 12:13:23 2017-date Tue Jan 31 12:11:50 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02457/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2017-01-30-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Jan 31 12:13:23 2017-date Tue Jan 31 12:11:50 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Tue Jan 31 12:13:23 2017-date Tue Jan 31 12:11:50 2017 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Tue Jan 31 12:13:44 2017-date Tue Jan 31 12:11:53 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02457/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2017-01-30-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Jan 31 12:13:44 2017-date Tue Jan 31 12:11:53 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Tue Jan 31 12:13:44 2017-date Tue Jan 31 12:11:53 2017 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Tue Jan 31 12:13:44 2017-date Tue Jan 31 12:11:58 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02457/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2017-01-30-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Jan 31 12:13:44 2017-date Tue Jan 31 12:11:58 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Tue Jan 31 12:13:44 2017-date Tue Jan 31 12:11:58 2017 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Tue Jan 31 12:17:27 2017-date Tue Jan 31 12:13:49 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02457/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2017-01-30-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Jan 31 12:17:27 2017-date Tue Jan 31 12:13:49 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Tue Jan 31 12:17:27 2017-date Tue Jan 31 12:13:49 2017 s - exit: 21504

cmsbuild · 2017-01-31T11:38:28Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

…ductLabel' in the config file. This solves the crashes.

cmsbuild · 2017-02-02T09:29:47Z

Pull request #17264 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

ndaci · 2017-02-03T09:29:05Z

The 90X version (#17262) of this PR has been merged. Can we please test this PR again ?

civanch · 2017-02-03T11:15:57Z

please test

cmsbuild · 2017-02-03T11:16:14Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17610/console Started: 2017/02/03 12:18

cmsbuild · 2017-02-03T12:23:08Z

+1
Tested at: 2da1ab9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17264/17610/summary.html

cmsbuild · 2017-02-03T12:23:11Z

Comparison job queued.

cmsbuild · 2017-02-03T13:14:44Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17264/17610/summary.html

civanch · 2017-02-05T00:15:43Z

+1

cmsbuild · 2017-02-05T00:15:57Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

fwyzard · 2017-02-07T10:05:45Z

backport of #17262

ndaci · 2017-02-09T10:04:44Z

Do you think we can get this PR merged?

davidlange6 · 2017-02-13T16:39:34Z

+1

Add back call to consumes within loop.

e3f8793

cmsbuild added this to the Next CMSSW_8_0_X milestone Jan 24, 2017

cmsbuild added comparison-pending orp-pending pending-signatures simulation-pending tests-pending labels Jan 24, 2017

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Jan 31, 2017

cmsbuild added tests-started and removed tests-pending labels Jan 31, 2017

cmsbuild added pending-signatures simulation-rejected and removed fully-signed simulation-approved labels Jan 31, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jan 31, 2017

Add an if statement to check if there is a parameter called 'HepMCPro…

2da1ab9

…ductLabel' in the config file. This solves the crashes.

cmsbuild added comparison-pending simulation-pending tests-pending and removed tests-rejected labels Feb 2, 2017

cmsbuild added tests-started and removed tests-pending labels Feb 3, 2017

cmsbuild added tests-approved and removed tests-started labels Feb 3, 2017

cmsbuild added comparison-available and removed comparison-pending labels Feb 3, 2017

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Feb 5, 2017

cmsbuild added the backport label Feb 7, 2017

cmsbuild added orp-approved and removed orp-pending labels Feb 13, 2017

cmsbuild merged commit a220339 into cms-sw:CMSSW_8_0_X Feb 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add back call to consumes within loop in the MixingModule. #17264

Add back call to consumes within loop in the MixingModule. #17264

ndaci commented Jan 24, 2017

cmsbuild commented Jan 24, 2017

mdhildreth commented Jan 31, 2017

cmsbuild commented Jan 31, 2017 •

edited

cmsbuild commented Jan 31, 2017

mdhildreth commented Jan 31, 2017

davidlange6 commented Jan 31, 2017 via email

cmsbuild commented Jan 31, 2017

cmsbuild commented Jan 31, 2017

cmsbuild commented Feb 2, 2017

ndaci commented Feb 3, 2017

civanch commented Feb 3, 2017

cmsbuild commented Feb 3, 2017 •

edited

cmsbuild commented Feb 3, 2017

cmsbuild commented Feb 3, 2017

cmsbuild commented Feb 3, 2017

civanch commented Feb 5, 2017

cmsbuild commented Feb 5, 2017

fwyzard commented Feb 7, 2017 •

edited

ndaci commented Feb 9, 2017

davidlange6 commented Feb 13, 2017

Add back call to consumes within loop in the MixingModule. #17264

Add back call to consumes within loop in the MixingModule. #17264

Conversation

ndaci commented Jan 24, 2017

cmsbuild commented Jan 24, 2017

mdhildreth commented Jan 31, 2017

cmsbuild commented Jan 31, 2017 • edited

cmsbuild commented Jan 31, 2017

mdhildreth commented Jan 31, 2017

davidlange6 commented Jan 31, 2017 via email

cmsbuild commented Jan 31, 2017

cmsbuild commented Jan 31, 2017

cmsbuild commented Feb 2, 2017

ndaci commented Feb 3, 2017

civanch commented Feb 3, 2017

cmsbuild commented Feb 3, 2017 • edited

cmsbuild commented Feb 3, 2017

cmsbuild commented Feb 3, 2017

cmsbuild commented Feb 3, 2017

civanch commented Feb 5, 2017

cmsbuild commented Feb 5, 2017

fwyzard commented Feb 7, 2017 • edited

ndaci commented Feb 9, 2017

davidlange6 commented Feb 13, 2017

cmsbuild commented Jan 31, 2017 •

edited

cmsbuild commented Feb 3, 2017 •

edited

fwyzard commented Feb 7, 2017 •

edited