bsunanda:Run2-hcx98 Enable possibility of running GEN-SIM for some 2017 geometry and choosing Plan0/1/36 at DIGI-RECO level #17268
Conversation
…sing Plan0/1/36 at DIGI-RECO level
|
A new Pull Request was created by @bsunanda for CMSSW_9_0_X. It involves the following packages: Geometry/HcalCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
|
@civanch Could you please approve this? |
|
@bsunanda the PR is fine but there are few unusual differences in 21234.0 and 23234.0 WFs in HCal. ARe they expected? |
|
@civanch There was a bug which is relevant for Phase I detector for HB/HE overlap region. So there may be some difference in the comparison plot. Also use of testNumbering in GEN-SIM and DIGI step was not handled correctly earlier but that effect will be seen only for mixed geometry mode (so called Plan-1) |
|
+1 |
|
The tests are being triggered in jenkins. |
|
unhold |
|
Comparison job queued. |
|
@bsunanda , in HcalDDDSimConstants.cc line 68: "-fioff" is the fix? |
|
@civanch Yes it is a bug fix - but this part of the code is not used in the usual flow (fioff=0 for full detectors) |
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
simulation-approved
and removed
geometry-pending
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
@davidlange6 Could you merge this because Plan-1 version will be based on that IB? |
|
+1 |
Apply the effect of neutral density filter if TestNumbering is enabled. So if GEN-SIM is done with TestNumbering, one can choose separate grouping with different neutral density filter