Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve -Werror=format-truncation= issues #17272

Merged
merged 1 commit into from Jan 25, 2017

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jan 25, 2017

By default %f precision is 6 digits after comma. Same applies to
std::to_string() and operator<< on std::basic_ostream.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

By default %f precision is 6 digits after comma. Same applies to
std::to_string() and operator<< on std::basic_ostream.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_9_0_X.

It involves the following packages:

TBDataFormats/HcalTBObjects

@cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@davidlt
Copy link
Contributor Author

davidlt commented Jan 25, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17424/console Started: 2017/01/25 07:02

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@civanch @bsunanda - could you have a quick look at this?

@civanch
Copy link
Contributor

civanch commented Jan 25, 2017

@davidlange6 , for me a reasonable cleanup.

@bsunanda
Copy link
Contributor

@civanch @davidlange6 The only difference is that if the lines are more than 180 characters, it will not be truncated now which was done earlier. I cannot judge if this is relevant or intended for the operation

@davidlange6
Copy link
Contributor

That sounds like it can only be an improvement..

@davidlange6 davidlange6 merged commit f4a98ef into cms-sw:CMSSW_9_0_X Jan 25, 2017
@bsunanda
Copy link
Contributor

@civanch @davidlange6 The only difference is that if the lines are more than 180 characters, it will not be truncated now which was done earlier. I cannot judge if this is relevant or intended for the operation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants