Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add base configuration to allow arbitrary pileup functions on a stabl… #17287

Merged
merged 3 commits into from Jan 27, 2017

Conversation

mdhildreth
Copy link
Contributor

…e config

Simplify specification of pileup distributions by creating a base configuration for all other parameters. A new pileup distribution can be included by using this as a base and just supplying the pileup spectrum.

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Jan 25, 2017
@mdhildreth
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mdhildreth for CMSSW_9_0_X.

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17448/console Started: 2017/01/25 23:27

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #17287 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

@mdhildreth
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17463/console Started: 2017/01/27 03:42

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1
we should think of a script to update most of the configs we have...

@cmsbuild cmsbuild merged commit 625a01a into cms-sw:CMSSW_9_0_X Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants