Bugfix EcalSimProducer for APD simulation

[yiiyama]

I found a bug in a part of the code that's not used in the standard sequences (needed only if one wants to simulate ECAL barrel "spike" noise).
Ported from #17300

[cmsbuild]

A new Pull Request was created by @yiiyama (Yutaro Iiyama) for CMSSW_9_0_X.

It involves the following packages:

SimCalorimetry/EcalSimProducers

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17466/console Started: 2017/01/27 10:39

[cmsbuild]

+1
Tested at: 63bdaf2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17301/17466/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17301/17466/summary.html

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

hi @yiiyama - please change the title of this PR so that it describes the changes for the release notes. Thanks

[yiiyama]

@davidlange6 Sorry, indeed the title only said what the PR is not.. Updated.

[davidlange6]

+1