Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put unscheduled customs in order: external methods done applied after all internal (miniAOD) are done #17312

Merged
merged 1 commit into from Jan 30, 2017
Merged

put unscheduled customs in order: external methods done applied after all internal (miniAOD) are done #17312

merged 1 commit into from Jan 30, 2017

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Jan 29, 2017

there are no instances of --customise_unsch so far, which is probably why this was not noticed.
A large fraction of miniAOD definitions are in unscheduled customs calls.
Clearly, to customize on command line one needs to do it after all "official" changes are done.

@slava77devel
put unscheduled customs in a proper order: external methods are to be…
505c991 
… applied after all internal (miniAOD) are done

Conflicts:
	Configuration/Applications/python/ConfigBuilder.py
@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Jan 29, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_9_0_X.

It involves the following packages:

Configuration/Applications

@cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor Author

slava77 commented Jan 29, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 29, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17483/console Started: 2017/01/29 20:44

@cmsbuild
Copy link
Contributor

+1
Tested at: 505c991
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17312/17483/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17312/17483/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018

@davidlange6
Copy link
Contributor

Thanks @slava77

@davidlange6 davidlange6 merged commit 701f3ae into cms-sw:CMSSW_9_0_X Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available operations-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_9_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@slava77 @cmsbuild @davidlange6 @slava77devel