80X electron and photon energy regression for user analysis #17318
Conversation
…also, more efficient example
|
A new Pull Request was created by @rafaellopesdesa (Rafael Lopes de Sa) for CMSSW_8_0_X. It involves the following packages: EgammaAnalysis/ElectronTools @cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
analysis-approved
and removed
analysis-pending
pending-signatures
labels
| #include "Geometry/CaloEventSetup/interface/CaloTopologyRecord.h" | ||
|
|
||
| #include <vdt/vdtMath.h> | ||
| #include <TFile.h> |
There was a problem hiding this comment.
Hi @rafaellopesdesa - this include is not needed. Please remove it
|
Pull request #17318 was updated. @cmsbuild, @monttj, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
This is the current electron and photon energy and resolution regression recommended by the EGM group for 80X analysis. The documentation about it can be found here:
https://twiki.cern.ch/twiki/bin/view/CMS/EGMRegression (data-MC residuals will be release this week, but do not alter this PR).
This is a user-application and does not change any of the comparisons performed during tests. The reason why this does not go into RecoEgamma is because the structure of the regression changed substantially and the codes are no longer compatible (ie, it's not a simple change of configuration... even though the code is very similar... there was really no reason to do a different code all together). Since 80X cannot have changes in the RECO sequence, we would like to provide these energy regressions as a user-app code, as in this PR. This will only exist in 80X. In 81X and 90X the code will go into the RECO sequence (in RecoEgamma). The PRs will follow the inclusions of the tags in the GT, so that validation can be done. I've already requested the inclusion in the 90X GT and the PRs should follow shortly.