-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geometry updates: Tracker and Gem affecting 2017 and 2018 scenarios #17319
geometry updates: Tracker and Gem affecting 2017 and 2018 scenarios #17319
Conversation
A new Pull Request was created by @franzoni (Giovanni Franzoni) for CMSSW_9_0_X. It involves the following packages: Configuration/AlCa @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Hello @franzoni, |
given the splitting of phaseI 2017 VS phaseI 2018 introduced in the PR #17198 |
given what we’ve heard from the SP team, calling something 2018 is premature. I would suggest we concentrate our efforts on 2017 and an eventual phase 1 scenario that in any case can be dealt with after 2017 is sorted out. (meanwhile phase 2 tests essentially everything new in phase 1)
… On Jan 30, 2017, at 2:05 PM, Giovanni Franzoni ***@***.***> wrote:
given the splitting of phaseI 2017 VS phaseI 2018 introduced in the PR #17198
@davidlange6 @smuzaffar
do we expect the 2018 relcavals be included already in this PR
in the short matrix run at each PR ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
thanks @mmusich for your query. @arunhep and myself propose that we defer the update of the alignment for 2017 and 2018 to a later PR, possibly pre4, and to the 81X backport. Keep reading those who want the rational.
|
thanks @franzoni, my naive expectations on the impact of the missing conditions update go in the lines of your detailed analysis. It is nonetheless important for TRK POG to realize this update might slightly spoil the performance. |
Comparison job queued. |
Similarly to the previous updates in geometry (e.g. #17198 ) changes appear in 2017 workflows where one would not expect them, stemming from the altered psedorandom number sequence. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
@ianna |
@franzoni - done. The tags are correct. |
thanks @ianna ! @davidlange6 : thanks to quick follow up by @ghellwig , we have the updated fully consistent alignment discussed earlier #17319 (comment) |
Summary of changes in Global Tags
RunII simulation
PhaseI 2017 design scenario : 90X_upgrade2017_design_IdealBS_v4 as 90X_upgrade2017_design_IdealBS_v5 with the following changes:
PhaseI 2017 realistic scenario : 90X_upgrade2017_realistic_v5 as 90X_upgrade2017_realistic_v4 with the following changes:
PhaseI 2017 cosmics scenario : 90X_upgrade2017cosmics_realistic_peak_v5 as 90X_upgrade2017cosmics_realistic_peak_v4 with the following changes:
PhaseI 2018 design scenario : 90X_upgrade2018_design_IdealBS_v3 as 90X_upgrade2018_design_IdealBS_v2 with the following changes:
PhaseI 2018 realistic scenario : 90X_upgrade2018_realistic_v3 as 90X_upgrade2018_realistic_v2 with the following changes:
PhaseI 2018 cosmics scenario : 90X_upgrade2018cosmics_realistic_peak_v3 as 90X_upgrade2018cosmics_realistic_peak_v2 with the following changes: