Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geometry updates: Tracker and Gem affecting 2017 and 2018 scenarios #17319

Conversation

franzoni
Copy link

@franzoni franzoni commented Jan 30, 2017

Summary of changes in Global Tags

RunII simulation

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @franzoni (Giovanni Franzoni) for CMSSW_9_0_X.

It involves the following packages:

Configuration/AlCa

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@franzoni
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 30, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17500/console Started: 2017/01/30 18:03

@mmusich
Copy link
Contributor

mmusich commented Jan 30, 2017

Hello @franzoni,
assuming the change of the pixel geometry in DB involves among others, the same update as in #17245, I would be expecting the tracker alignment to be changed to pick-up consistently the change from 290um to of 300um sensor thickness in Fpix, that is supposed to affect positions of the senstive volumes, even if it is just a few um.
Are you planning to update those payloads in this PR later?
@ghellwig @veszpv

@franzoni
Copy link
Author

given the splitting of phaseI 2017 VS phaseI 2018 introduced in the PR #17198
@davidlange6 @smuzaffar
do we expect the 2018 relcavals be included already in this PR
in the short matrix run at each PR ?

@davidlange6
Copy link
Contributor

davidlange6 commented Jan 30, 2017 via email

@franzoni
Copy link
Author

Are you planning to update those payloads in this PR later?

thanks @mmusich for your query.

@arunhep and myself propose that we defer the update of the alignment for 2017 and 2018 to a later PR, possibly pre4, and to the 81X backport. Keep reading those who want the rational.

  • what we get from hte PR Pixel Material Budget Changes (updated) #17245 is a 10 micron effect in FPIX; hence residuals as seen in tracking will be a fraction of 10 micron, via the non trivial jacobian - the signicance of which to be compared with the intrinsic cluster uncertainty
  • we don't have , yet, the updated alignment consistent with Pixel Material Budget Changes (updated) #17245 ( we've already informed tracker alignment that it's needed @mschrode @ghellwig )
  • we can't assess quantitatively the impact on tracking quality of not being fully consistent; yet the inconsistency we're talking about today is more than a factor 10 smaller than what we had in the 81X_upgrade2017_HCALdev_v2_HcalGeom-v1 campaign (where the discrepancy were 100 - hundreds microns affecting bpix in the phi coordinate). As such, what's in this PR is likely going to be useful for tracking , provided we keep this effect in mind @makortel @rovere @VinInn ( please tracking pog and validators, comment if you contest our rational )

@mmusich
Copy link
Contributor

mmusich commented Jan 30, 2017

thanks @franzoni, my naive expectations on the impact of the missing conditions update go in the lines of your detailed analysis. It is nonetheless important for TRK POG to realize this update might slightly spoil the performance.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@franzoni
Copy link
Author

franzoni commented Jan 30, 2017

Similarly to the previous updates in geometry (e.g. #17198 ) changes appear in 2017 workflows where one would not expect them, stemming from the altered psedorandom number sequence.
Difficult to conclude on the available statistics wether changes are as expected or not, at least for what concerns the changes in pixel.
Do we expect any DQM-level change stemming from the GEM inclusion (have not found GEM in DQM) ?

@franzoni
Copy link
Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@franzoni
Copy link
Author

@ianna
it would be great if you could double-check
that the tags we've included do correspond to what you've request in hn and we've agreed verbally
Thanks!

@ianna
Copy link
Contributor

ianna commented Jan 30, 2017

@franzoni - done. The tags are correct.

@davidlange6 davidlange6 merged commit 4c6b1df into cms-sw:CMSSW_9_0_X Jan 31, 2017
@franzoni
Copy link
Author

thanks @ianna !

@davidlange6 : thanks to quick follow up by @ghellwig , we have the updated fully consistent alignment discussed earlier #17319 (comment)
Are we still in time for pre3
(if not of course we'll submit a PR in any case - less urgently) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants