New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fastsim calorimetry: new tuning of HF #1734
Conversation
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Hi @lveldere, This pull request is not mergeable, could you please rebase it? |
Conflicts: FastSimulation/Calorimetry/interface/HCALResponse.h FastSimulation/Calorimetry/src/HCALResponse.cc Conflicts due to new handling of random number generators for multithreading
@nclopezo |
to pre12 / 71X. |
Multithreading fixes -- Removed DQM and PoolDBOutputServices from threaded jobs
A new Pull Request was created by @lveldere for CMSSW_7_0_X. fastsim calorimetry: new tuning of HF It involves the following packages: Alignment/LaserAlignment @diguida, @deguio, @lveldere, @cmsdoxy, @cerminar, @Martin-Grunewald, @mommsen, @anton-a, @thspeer, @rcastello, @bendavid, @perrotta, @civanch, @vlimant, @mulhearn, @fwyzard, @eliasron, @ktf, @vciulli, @Dr15Jones, @demattia, @mdhildreth, @ianna, @rovere, @giamman, @slava77, @ggovi, @vadler, @fabiocos, @apfeiffer1, @danduggan, @emeschi, @alja, @franzoni can you please review it and eventually sign? Thanks. |
Pull request #1734 was updated. @diguida, @deguio, @lveldere, @cmsdoxy, @cerminar, @Martin-Grunewald, @mommsen, @anton-a, @thspeer, @rcastello, @bendavid, @perrotta, @civanch, @vlimant, @mulhearn, @fwyzard, @eliasron, @ktf, @vciulli, @Dr15Jones, @demattia, @mdhildreth, @ianna, @rovere, @giamman, @slava77, @ggovi, @vadler, @fabiocos, @apfeiffer1, @danduggan, @emeschi, @alja, @franzoni can you please check and sign again. |
again, it looks like something went wrong... |
-1 Suggest rebasing! |
i'm still working on it |
replaced by #1959 |
added back the -fPIC
by reza.goldouzian@cern.ch