Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhysicsTools/SelectorUtils : Changes needed to compile with macOS clang and libc++ #17356

Merged
merged 1 commit into from Feb 3, 2017
Merged

PhysicsTools/SelectorUtils : Changes needed to compile with macOS clang and libc++ #17356

merged 1 commit into from Feb 3, 2017

Conversation

gartung
Copy link
Member

@gartung gartung commented Jan 31, 2017

Clang libc++ did not have a format?? for %d

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X.

It involves the following packages:

PhysicsTools/SelectorUtils

@cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@gartung gartung changed the title Changes needed to compile with macOS clang and libc++ PhysicsTools/SelectorUtils : Changes needed to compile with macOS clang and libc++ Jan 31, 2017
@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17570/console Started: 2017/02/01 19:53

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17356/17570/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7
  • 21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4
  • 23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8

@davidlange6 davidlange6 merged commit ccb181d into cms-sw:CMSSW_9_0_X Feb 3, 2017
@gartung gartung deleted the PhysicsTools-SelectorUtils-macos-clang-fixes branch March 13, 2017 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants