Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 17098 #17363

Merged
merged 1 commit into from Feb 1, 2017
Merged

Fix 17098 #17363

merged 1 commit into from Feb 1, 2017

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Feb 1, 2017

Fix source of various failures due to #17098

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_9_0_X.

It involves the following packages:

Validation/RecoHI

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@kkrajczar, @RylanC24 this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17554/console Started: 2017/02/01 10:04

@VinInn
Copy link
Contributor Author

VinInn commented Feb 1, 2017

This fix only HI. working on FastSim (takes ages just to do the python step...)

@VinInn
Copy link
Contributor Author

VinInn commented Feb 1, 2017

let's guess: wf25400 is using tracks from pileup files generated NOT with 17098...

@davidlange6
Copy link
Contributor

davidlange6 commented Feb 1, 2017 via email

@davidlange6 davidlange6 merged commit 7fbbfe6 into cms-sw:CMSSW_9_0_X Feb 1, 2017
@VinInn
Copy link
Contributor Author

VinInn commented Feb 1, 2017

maybe we shall make the TrajParam persistent just for this use case

@VinInn
Copy link
Contributor Author

VinInn commented Feb 1, 2017

or Refit

@VinInn
Copy link
Contributor Author

VinInn commented Feb 1, 2017

Essentially FastSim is violating the new trend that RecoTier is obsolete

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17363/17554/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7
  • 21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4
  • 23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants