Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove comparisons of nonnull objects against 0 #17364

Merged
merged 1 commit into from Feb 2, 2017
Merged

remove comparisons of nonnull objects against 0 #17364

merged 1 commit into from Feb 2, 2017

Conversation

davidlange6
Copy link
Contributor

indicated by warnings in gcc630

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Feb 1, 2017
@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_9_0_X.

It involves the following packages:

RecoTracker/SingleTrackPattern

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @dgulhan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17553/console Started: 2017/02/01 10:04

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

+1
Tested at: 11c009b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17364/17553/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17364/17553/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7
  • 21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4
  • 23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8

slava77
slava77 reviewed Feb 2, 2017
View reviewed changes
RecoTracker/SingleTrackPattern/src/CRackTrajectoryBuilder.cc
if ((seed_plus && (ych<yref)) || (!(seed_plus) && (ych>yref)))
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of dropping braces for one-line if/else.
It's easy to get things pretty wrong this way if any edits are to be made around these lines

@slava77
Copy link
Contributor

slava77 commented Feb 2, 2017

+1

for #17364 11c009b

  • technical (removing equivalent of "if (true)" )
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor Author

+1

@cmsbuild cmsbuild merged commit 95e2a80 into cms-sw:CMSSW_9_0_X Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slava77 slava77 slava77 left review comments

Assignees
No one assigned
Labels
comparison-available fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_0_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidlange6 @cmsbuild @slava77