Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calculation of TrackingParticle::numberOfHits() #17382

Merged
merged 3 commits into from Feb 2, 2017
Merged

Fix calculation of TrackingParticle::numberOfHits() #17382

merged 3 commits into from Feb 2, 2017

Commits on Feb 2, 2017

  1. Sort SimHits by their time of flight for the number of hits calculation 

    Because the processType and particleType are taken from the "first"
SimHit of a SimTrack, it is important to get the "first" right.
Previously it was the one with the smallest index in the SimHit
vector, but this fails for Phase2 tracker where also the outer tracker
(OT) SimHits are in the same event products as pixel SimHits, and for
some reason the OT SimHits are inserted before the pixel SimHits.

I believe using the time of flight is more robust way to decide which
SimHit is "first".
    @makortel
    makortel committed Feb 2, 2017
    Copy the full SHA
    e64fd42 View commit details
    Browse the repository at this point in the history

  2. Small performance optimization

    @makortel
    makortel committed Feb 2, 2017
    Copy the full SHA
    4c69a0a View commit details
    Browse the repository at this point in the history

  3. Ignore upfront SimHits with particleType different from SimTrack pdgId 

    These are anyway ignored from the number of hit calculation, so let's
ignore them from the "first hit" deduction as well.
    @makortel
    makortel committed Feb 2, 2017
    Copy the full SHA
    b9b75bf View commit details
    Browse the repository at this point in the history