add 10 electrons gun gen fragment #17394
Conversation
|
A new Pull Request was created by @mtosi (mia tosi) for CMSSW_9_0_X. It involves the following packages: Configuration/Generator @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
Ciao Mia,
|
|
@govoni Hi Pietro, the generator fragment runs ok. This is the output of running 10 events using the same configuration as the TenMuE wf: https://rcoelhol.web.cern.ch/rcoelhol/TenEE/?match=Electron It looks healthy for EGM. About filter names and other technical details, that is outside my expertise. |
|
thanks @govoni and @rafaellopesdesa ! I need to backport this PR to 80x and 81x |
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| # Modified from Configuration/Generator/python/TenMuE_0_200_pythia8_cfi.py | ||
| generator = cms.EDFilter("Pythia8EGun", |
There was a problem hiding this comment.
Ciao Mia, isn't "Pythia8EGun" the same name used for the ten muon gun EDFilter? Wouldn't it be better to change the name here?
There was a problem hiding this comment.
I'm confused by your comment, that name is not the name of the module
(and actually, I checked and I saw all fragments are using "generator" as name and I find it as expected, actually)
but it is the name of the CMSSW template which defines the type of EDFilter we want to run ...
There was a problem hiding this comment.
I don't know why you need the string in general, but I think that you can choose it. See for example here:
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideGenFilters
Anyhow, as one either produces ten muons or ten electrons, I don't see a big overlap problem here.
|
@rafaellopesdesa thanks a lot for the plots! |
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
assign dmv (just to confirm that @fabozzi is also in agreement) |
|
assign pdmv |
|
+1 |
cmsbuild
added
fully-signed
pdmv-approved
and removed
pdmv-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
as requested by EGM for both offline and HLT reconstruction/ID/etc validation
this is the gen fragment for generating events w/ 10 electrons w/
this gen fragment is a copy-n-paste of the TenMu gun
I simply changed -13 into -11
and increased the eta acceptance
this will be used for standard relval samples for release validation
and it will help the development and tuning of the EGM reco/ID/etc
@paramatti @fcouderc @gpasztor