New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make TestSiStripDCS unit test to return non-zero exit code if failled #17401
Conversation
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_9_0_X. It involves the following packages: CalibTracker/SiStripDCS @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
thanks @smuzaffar , adding @hqucms for information |
@smuzaffar does this close #14270 ? |
@mmusich , yes it does. I did not realize that there is an issue fr this too. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
Default values of missing parameters are added from
https://github.com/cms-sw/cmssw/blob/CMSSW_9_0_X/CalibTracker/SiStripDCS/test/dcs_o2o_template_cfg.py#L75
https://github.com/cms-sw/cmssw/blob/CMSSW_9_0_X/CalibTracker/SiStripDCS/test/dcs_o2o_template_cfg.py#L78