New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[90X] Update of the Millepede Production System #17408
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
348a248
Fix 'mps_parse_pedechi2hist.py'.
gregor-mittag cfa7827
Fix variable replacement in pede-script-template.
gregor-mittag 37a129b
Fix style of 'mps_check.py'.
gregor-mittag 3c9729d
Add handling of missing output file (rare case).
gregor-mittag c6779db
Use context manager to open files in 'mps_check.py'.
gregor-mittag 079762c
Add protection against accidentally using data prior to first IOV.
gregor-mittag e1ef6b6
Ignore auto-generated ROOT file in MPS validation.
gregor-mittag 5627d8c
Fix style of 'mps_fetch.py'.
gregor-mittag b81a6b9
Add recovery from previous failures in 'mps_fetch.py'.
gregor-mittag 06cc2da
Fixed memory usage calculation.
gregor-mittag a83aac4
Fix input validation in 'mps_create_file_lists.py'.
gregor-mittag c12007b
Fix automatic single-IOv input for '-w' option of 'mps_alisetup.py'.
gregor-mittag 8326655
Further improve input validation of mps_create_file_lists.py.
gregor-mittag 7aeb91b
Make mps_create_file_lists.py more robust against DAS issues.
gregor-mittag a0feb84
Fixed shuffling of files in case a DAS cache is used.
gregor-mittag 9c6aa5b
Create dataset cff-files also for alignment datasets.
gregor-mittag 3dfacc6
Enable forwarding of proxy for MPS.
gregor-mittag d53ffda
Fix '-f/--force-merge' option of 'mps_fire.py'.
gregor-mittag b7dce9f
Fix behaviour of mps_create_file_lists.py if only help is wanted.
gregor-mittag d63f96a
Speed-up of file creation script.
gregor-mittag bc6e64d
Better log message for file-list creation script.
gregor-mittag bc73c80
Enable usage of UpsilonMuMu data in MillePede workflow.
gregor-mittag 3815b8d
Define default pede settings and provide helper to customize them.
gregor-mittag File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Alignment/MillePedeAlignmentAlgorithm/python/mpsvalidate/.gitignore
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
TrackerTree.root |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @ghellwig
for information, when the framework was to look for conditions not covered by any IOV, this : https://hypernews.cern.ch/HyperNews/CMS/get/dataopsrequests/17299/1.html is what happens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @franzoni,
yes, I have seen this failure, but this check has a different purpose.
This is checking the output IOV definition, e.g. if the alignment is supposed to deliver IOVs starting from run 200000 and data is used from , e.g., run 190000.
Without the check, the resulting alignment of the high-level structures would not be affected because the data does not fall into any IOV, but the module-level alignment would be slightly affected because the modules are assumed to be constant wrt. the high-level structures, i.e. all data is used for the module-level alignment. That means data from all IOVs and without this check even from periods prior to any defined output IOV.
In addition this check also prevents problems in a second iteration where the input IOVs are the output IOVs from the first iteration. In this case, we would get the kind of message you are pointing to, but only after running an alignment which might have taken up to two days.