Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending tracking ntuples for phase2 #17425

Merged
merged 12 commits into from Feb 7, 2017

Conversation

ebrondol
Copy link
Contributor

@ebrondol ebrondol commented Feb 6, 2017

Main changes:

  • Introducing a new HitType (Phase2OT)
  • Adapting the code to get phase2 OT clusters
  • Removing chargeFraction for phase2 because not supported

This PR has been tested in CMSSW_9_0_X_2017-02-06-1100 for Phase2 workflow - it should be compatible with Phase1. @makortel can you maybe confirm?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

A new Pull Request was created by @ebrondol for CMSSW_9_0_X.

It involves the following packages:

Validation/RecoTrack

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @wmtford, @mtosi, @dgulhan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@makortel
Copy link
Contributor

makortel commented Feb 6, 2017

@cmsbuild, please test

@makortel
Copy link
Contributor

makortel commented Feb 6, 2017

Thanks @ebrondol!

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17636/console Started: 2017/02/06 15:22

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 90003b6 into cms-sw:CMSSW_9_0_X Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants