Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TString where possible and use specific conversion functions #17427

Merged
merged 1 commit into from Feb 7, 2017

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Feb 6, 2017

This is because we are in C++17 and TString support both conversions, std::string and std::string_view and so does C++ Standard Library (e.g., std::string ctors and operators) thus compiler doesn't know what to do.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

A new Pull Request was created by @davidlt for CMSSW_9_0_X.

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@davidlt
Copy link
Contributor Author

davidlt commented Feb 7, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17655/console Started: 2017/02/07 10:10

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 30ab476 into cms-sw:CMSSW_9_0_X Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants