Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert FwdPtrCollectionFilter to stream filter #17428

Merged

Conversation

knoepfel
Copy link
Contributor

@knoepfel knoepfel commented Feb 6, 2017

It did not appear necessary to me to create a stream filter of this type separate from a legacy filter. In other words, the two instantiations of this template looked conducive to being stream filters.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

A new Pull Request was created by @knoepfel (Kyle Knoepfel) for CMSSW_9_0_X.

It involves the following packages:

CommonTools/ParticleFlow
CommonTools/UtilAlgos

@cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @makortel, @ahinzmann, @gkasieczka, @cbernet this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 6, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17640/console Started: 2017/02/06 17:06

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17642/console Started: 2017/02/06 17:30

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

@slava77
Copy link
Contributor

slava77 commented Feb 7, 2017

+1

for #17428 b2784d1

  • change to edm::stream::EDFilter and also refactored to a shorter and what appears to be equivalent implementation
  • jenkins tests pass and comparisons with baseline show no differences

@davidlange6 davidlange6 merged commit c8ca94d into cms-sw:CMSSW_9_0_X Feb 7, 2017
@knoepfel knoepfel deleted the convert-FwdPtrCollectionFilter branch February 7, 2017 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants