Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted to stream module #17431

Merged
merged 2 commits into from Feb 20, 2017
Merged

Converted to stream module #17431

merged 2 commits into from Feb 20, 2017

Conversation

sabasehrish
Copy link
Contributor

converted DTTFFEDSim to stream module.

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Feb 6, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

A new Pull Request was created by @sabasehrish for CMSSW_9_0_X.

It involves the following packages:

EventFilter/DTTFRawToDigi

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 7, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17653/console Started: 2017/02/07 05:37

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

+1
Tested at: 0f897f9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17431/17653/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17431/17653/summary.html

@sabasehrish
Copy link
Contributor Author

@Dr15Jones

@rekovic
Copy link
Contributor

rekovic commented Feb 20, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5266f7b into cms-sw:CMSSW_9_0_X Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sabasehrish @cmsbuild @slava77 @rekovic @davidlange6