Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

76X Fireworks: Update URL with samples for US users #17435

Merged
merged 1 commit into from Mar 23, 2017
Merged

76X Fireworks: Update URL with samples for US users #17435

merged 1 commit into from Mar 23, 2017

Conversation

alja
Copy link
Contributor

@alja alja commented Feb 6, 2017

Duplicate #17415

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Feb 6, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_6_X.

It involves the following packages:

Fireworks/Core

@cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17671/console Started: 2017/02/07 17:06

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

+1
Tested at: ed0156d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17435/17671/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@alja
Copy link
Contributor Author

alja commented Feb 8, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 24ab1c0 into cms-sw:CMSSW_7_6_X Mar 23, 2017
@alja alja deleted the patch-6 branch May 11, 2017 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-notrun fully-signed orp-approved tests-approved visualization-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alja @cmsbuild @Dr15Jones @davidlange6