Turn-on by default the MaxSample algo for EB for gain-switching hits

[emanueledimarco]

In 90X this is the tested option on both data and MC. It could be replaced by more sophisticated multifit versions if tested OK in time.
This is related to PR #17259 (80X) and PR #17279 (90X).

[cmsbuild]

A new Pull Request was created by @emanueledimarco (Emanuele Di Marco) for CMSSW_9_0_X.

It involves the following packages:

RecoLocalCalo/EcalRecProducers

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17663/console Started: 2017/02/07 14:07

[cmsbuild]

+1
Tested at: d3d9722
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17442/17663/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17442/17663/summary.html

[slava77]

@emanueledimarco
if I'm not mistaken, in 80X we switched from max sample to global reco for the gain-switch
ed952ac

Is the implementation delivered with gainSwitchUseMaxSampleEB appropriate for that or will you need to make a change to it?

[argiro]

@slava77, ed952ac was for the re-miniaAOD fix, which is a patched workflow. This is a fix for the standard production workflow embedded in the multifit module.

[slava77]

@argiro
just to clarify, do you mean that the issue with setting of kOutTime seen in the patched workflow is not happening here (and the flags are set appropriately)?

[argiro]

On 08 Feb 2017, at 11:06, Slava Krutelyov ***@***.***> wrote: @argiro just to clarify, do you mean that the issue with setting of kOutTime seen in the patched workflow is not happening here (and the flags are set appropriately)?

yes, the Multifit module does set flags appropriately

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[slava77]

+1

for #17442 d3d9722

• ecal EB hit reco change as described, affecting both data and MC
• jenkins tests pass and comparisons show small differences only in RunSinglePh2016B wf 136.731, consistent with the change made in this PR
• local test with single ele 1TeV gun shows mostly very small changes. The most significant change is in the low-chi2 EB rechit population; the hit energies are essentially unchanged; occasional changes in EB hit energies propagate downstream without any particular pattern

The effect on data with gain switch is expected to be significant, in agreement with earlier studies in 80X.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1