Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted to stream module #17451

Merged
merged 1 commit into from Feb 9, 2017

Conversation

sabasehrish
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

A new Pull Request was created by @sabasehrish for CMSSW_9_0_X.

It involves the following packages:

EventFilter/RPCRawToDigi

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17678/console Started: 2017/02/07 22:18

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2017

@slava77
Copy link
Contributor

slava77 commented Feb 8, 2017

+1

for #17451 8e1978b

  • converted RPCPackingModule to edm::stream; somewhat cursory check of module implementation and related data members suggests this is thread safe
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c7aa985 into cms-sw:CMSSW_9_0_X Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants