New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GCC 7 (use snprintf, inc. buffer size, remove not needed code) #17457
Conversation
A new Pull Request was created by @davidlt for CMSSW_9_0_X. It involves the following packages: EventFilter/EcalTBRawToDigi @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
seedForBW = seedVoid; | ||
} | ||
else if(theBWSeedType == "fromFWFit") { | ||
if(theBWSeedType == "fromFWFit") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks incorrect: "noSeed" will now go to the final "else" with a LogWarning.
The expected behavior should the that theBWSeedType == "noSeed"
is a no-op
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
80a040f
to
f38740f
Compare
Pull request #17457 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch