Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pixelTracks imports #17470

Merged
merged 2 commits into from Feb 11, 2017
Merged

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Feb 9, 2017

This PR is a follow-up to #17438 adding a pixelTracks_cfi that imports from descriptions-generated pixelTracksDefault_cfi, and changing all affected files to import from `pixelTracks_cfi. This should have been done already in #17170, but somehow I missed it.

The PixelTracksL2Tau_cfi (*) referenced TrackingRegionsFromBeamSpotAndL2Tau (in pre-#17170 way), so I added TrackingRegionsFromBeamSpotAndL2TauEDProducer to produce the TrackingRegions to event as required by the new seeding framework. I'm not sure how useful PixelTracksL2Tau_cfi is anymore though, as now it has just a clone of PixelTracksProducer and a TrackingRegionsFromBeamSpotAndL2TauEDProducer module via import (i.e. hit doublet/triplet/quadruplet producers and filter+fitter+cleaner are missing).

(*) I guess this is being used for ConfDB parsing since it was modified in #17438.

Tested in 9_0_0_pre3, no changes expected.

@rovere @VinInn @Martin-Grunewald

@makortel
Copy link
Contributor Author

makortel commented Feb 9, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17714/console Started: 2017/02/09 13:24

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2017

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_0_X.

It involves the following packages:

RecoPixelVertexing/PixelTrackFitting
RecoTauTag/HLTProducers
RecoTracker/TkSeedGenerator

@perrotta, @cmsbuild, @silviodonato, @cvuosalo, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @dgulhan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2017

@silviodonato
Copy link
Contributor

+1

@slava77
Copy link
Contributor

slava77 commented Feb 10, 2017

+1

for #17470 47a7493

  • mainly a technical update
  • jenkins tests pass and comparisons with baseline show no differences

@slava77
Copy link
Contributor

slava77 commented Feb 10, 2017

+1
missed originally in the #17470 (comment)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5bb5a5d into cms-sw:CMSSW_9_0_X Feb 11, 2017
@makortel makortel deleted the fixPixelTracksImports branch February 12, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants