New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated pixel cabling (2017 & 2018) and EGM regressions #17479
updated pixel cabling (2017 & 2018) and EGM regressions #17479
Conversation
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @franzoni (Giovanni Franzoni) for CMSSW_9_0_X. It involves the following packages: Configuration/AlCa @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
Comparison job queued. |
can you please educate me on how the is used in the MC digi-reco sequence ? https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_0_X_2017-02-09-2300+17479/18269/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/ can you please comment on whether these changes are expected and desired, or not ? @slava77 you may want to keep an eye on this too |
given this explanations: could it be that the same physical hits in the same geometric volumes in space That would explain the fact that tracking is in no way affected. |
please test |
The tests are being triggered in jenkins. |
The tests are being triggered in jenkins. |
@franzoni , test should run now. Last time they failed because the weekly IBs area was cleaned up and scram DB was missing. I will fix this in next days so that weekly cleanup does not break PR tests |
thanks @smuzaffar ! |
Comparison job queued. |
as expected the introduction of the egamma regressions @veszpv @tvami, |
@franzoni Your explanation is correct: the new cabling map associates a different FED+channel number for the same DetId. Since this mapping is done consistently in both digitization (digi2raw) and reconstruction (raw2digi), it is transparent in terms of high level reco. However, the content of RAW, the intermediate step, will be different. So the differences in validation are expected, as those plots are meant to display information from the RAW content. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
@davidlange6 Thanks, @veszpv |
@davidlange6 |
+1 |
np! |
In this PR we'll take care of
. see: https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2815/1/1.html
. see: https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2806.html
The first commit only takes are of pixel cabling. I'll put in the regressions after the first round of tests (full documentation will follow), updating this PR with a new commit