Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for conddb edit tool #17486

Merged
merged 4 commits into from Feb 13, 2017

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Feb 10, 2017

In this PR:

  • IOV schema fixed in the sqlalchemy model to remove the payload hash from the primary keys
  • edit tag fixed to support sqlite manipulations

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for CMSSW_9_0_X.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ggovi
Copy link
Contributor Author

ggovi commented Feb 10, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17738/console Started: 2017/02/10 16:52

@cmsbuild
Copy link
Contributor

Pull request #17486 was updated. @ggovi, @cmsbuild, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Feb 10, 2017

Ciao Giacomo, @ggovi.

cmsrel CMSSW_9_0_X_2017-02-10-1100
cd CMSSW_9_0_X_2017-02-10-1100/src/
cmsenv
git cms-merge-topic 17486
scramv1 b -j 8
cmsenv
conddb_import -c sqlite_file:SiStripBadComponents_FailureScenario_PS1.db -f frontier://FrontierProd/CMS_CONDITIONS -i SiStripBadComponents_FailureScenario_PS1 -t SiStripBadComponents_FailureScenario_PS1
conddb --force --db SiStripBadComponents_FailureScenario_PS1.db edit --type tag SiStripBadComponents_FailureScenario_PS1
[2017-02-10 16:34:08,147] INFO: Connecting to SiStripBadComponents_FailureScenario_PS1.db [sqlite:///SiStripBadComponents_FailureScenario_PS1.db]
   Since  Insertion Time              Payload                                   
   -----  --------------------------  ----------------------------------------  
-  1      2017-02-10 15:32:49.506626  6ba6116331f89962932db238c4f354e1963b6b55  
+  100    2017-02-10 15:32:49.506626  6ba6116331f89962932db238c4f354e1963b6b55  

Confirm changes? [n] y
Please provide an editing note:  change the IOV from 1 to 100

works fine! (sorry for previous message, overlooked to re-do cmsenv in the local installations)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@ggovi
Copy link
Contributor Author

ggovi commented Feb 13, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5248eca into cms-sw:CMSSW_9_0_X Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants