add a public accessor for the definition of "invalid module id" #1750
Conversation
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_0_X. add a public accessor for the definition of "invalid module id" It involves the following packages: DataFormats/Provenance @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
rebased on top of CMSSW_7_0_X_2013-12-10-0200 |
|
Pull request #1750 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again. |
| { | ||
| return std::numeric_limits<unsigned int>::max(); | ||
| } | ||
|
|
There was a problem hiding this comment.
I'd prefer the function to be called invalidID(). I known the other static has get in its name, but that was becuase it changes each time it is called (a better name would have been getNewUniqueID().
There was a problem hiding this comment.
Also, best to move the body of the function within the #if ... #else section and then just use ; for the second declaration. That way Reflex also never has to see std::numeric_limits.
|
Pull request #1750 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again. |
| return std::numeric_limits<unsigned int>::max(); | ||
| } | ||
| #else | ||
| static unsigned int invalidID() { |
There was a problem hiding this comment.
Just make it undefined (i.e. don't give it any body). This is only seen by parser and never actually gets compiled.
|
Done. .A |
|
Pull request #1750 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Framework -- Add a public accessor for the definition of "invalid module id"
No description provided.