Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protection against sqrt(negative value) due to numerical rounding ef... #1752

Merged
merged 1 commit into from Dec 10, 2013

Conversation

Martin-Grunewald
Copy link
Contributor

...fects

Fixes pre9 relval crashes observed here: https://hypernews.cern.ch/HyperNews/CMS/get/relval/2765.html

between 1 and 6 percent of the HLTD jobs failed due to this error

An exception of category 'FatalRootError' occurred while
   [0] Processing run: 208307 lumi: 263 event: 412070218
   [1] Running path 'HLT_Ele30_CaloIdVT_TrkIdT_PFNoPUJet100_PFNoPUJet25_v9'
   [2] Calling event method for module HLTPFJetCollectionsForElePlusJets/'hltEle30CaloIdVTTrkIdTCleanAK5PFNoPUJet'
   Additional Info:
      [a] Fatal Root Error: @SUB=TVector3::PseudoRapidity
transvers momentum = 0! return +/- 10e10

Essentially, due to numerical rounding, a sqrt of s slightly negative number is taken,
which produces a "nan" which ends up as the jetarea and has knock on effects
when calculating jet energy corrections updating the jet kinematics and thus the
jet eta.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_0_X.

Add protection against sqrt(negative value) due to numerical rounding ef...

It involves the following packages:

RecoJets/JetProducers

@nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@ktf
Copy link
Contributor

ktf commented Dec 10, 2013

Bypassing signatures to have a few hours advantage when building pre10. @slava77 @thspeer complain if not ok.

ktf added a commit that referenced this pull request Dec 10, 2013
Reco fixes -- Add protection against sqrt(negative value) due to numerical rounding effects.
@ktf ktf merged commit a4b6ffa into cms-sw:CMSSW_7_0_X Dec 10, 2013
@Martin-Grunewald Martin-Grunewald deleted the FixJetAreaCalculation branch December 11, 2013 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants